search

j-fu / VoronoiFVM.jl

Solution of nonlinear multiphysics partial differential equation systems using the Voronoi finite volume method
MIT License
183 stars 33 forks source link

bugfix for bfacefactors #96

Closed j-fu closed 5 months ago

j-fu commented 5 months ago

Nodefactors weren't created in the right sequence. Robin and Neuamann boundary conditions in 3D were affected.

j-fu commented 5 months ago

@DavidBrust,@DilaraAbdel

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b79ebda) 85.33% compared to head (6ec3f70) 85.34%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #96 +/- ## ========================================== + Coverage 85.33% 85.34% +0.01% ========================================== Files 24 24 Lines 2762 2764 +2 ========================================== + Hits 2357 2359 +2 Misses 405 405 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dilaraabdel commented 5 months ago

@j-fu thanks for pointing out and fixing! I checked my 3d example, the changes have no effect on my calculations (and the test values).