search

j-hc / revanced-magisk-module

Extensive ReVanced builder. Builds both modules and APKs. Updated daily.
https://t.me/rvc_magisk
GNU General Public License v3.0
4.18k stars 796 forks source link

Some patches fail #438

Closed Lassie111 closed 6 months ago

Lassie111 commented 6 months ago

https://github.com/Lassie111/revanced-magisk-module/actions/runs/9016399136/job/24772918587#step:6:119

j-hc commented 6 months ago

DO NOT REPORT REVANCED BUGS IN THIS REPO Describe the bug of the rvmm builder or the modules

Lassie111 commented 6 months ago

Patching just with revanced-cli-4.6.0 locally worked without errors, that's why I was not sure whether it is a Revanced bug or not.

j-hc commented 6 months ago

it fails with the stock revanced cli too

Lassie111 commented 6 months ago

it fails with the stock revanced cli too

Ah, that's true, it was my fault. I tested locally with youtube, instead of youtube music, but it's the music that fails. I got confused by the mixed github actions log which prints the log for both apps simultaneously (maybe because it's running them in parallel).