search

j-hc / revanced-magisk-module

Extensive ReVanced builder. Builds both modules and APKs. Updated daily.
https://t.me/rvc_magisk
GNU General Public License v3.0
4.06k stars 799 forks source link

Issue with ci and build.md #504

Closed E85Addict closed 3 weeks ago

E85Addict commented 3 weeks ago

https://github.com/j-hc/revanced-magisk-module/blob/b621def2c56953e1cb4f18a8f98f14275d2721d9/utils.sh#L92

After the new changes that added dev as an option on prebuilt version (amazing btw) it seems that this line here is duplicating the versions and source that already exist in the changelog.md.

This also made me realize that the config_update() function should probably check if it should look for latest release or prerelease aka "dev"

E85Addict commented 3 weeks ago

I just ran the current repo as is and this is the build.md it output. 

YouTube: 19.16.39  
Music (arm64-v8a): 7.19.51  
Music (arm-v7a): 7.19.51  
Music-Extended (arm64-v8a): 7.17.51  
Music-Extended (arm-v7a): 7.17.51  
YouTube-Extended: 19.16.39  
Twitter: 10.59.0-release.0  
Twitch: 16.9.1  
TikTok: 32.5.3  

Install [Microg](https://github.com/ReVanced/GmsCore/releases) for non-root YouTube and YT Music APKs  
Use [zygisk-detach](https://github.com/j-hc/zygisk-detach) to detach root ReVanced YouTube and YT Music from Play Store  

[revanced-magisk-module](https://github.com/j-hc/revanced-magisk-module)

CLI: inotia00/revanced-cli-4.6.1-all.jar  
Integrations: inotia00/revanced-integrations-1.13.1.apk  
Patches: inotia00/revanced-patches-4.13.1.jar  
[Changelog](https://github.com/inotia00/revanced-patches/releases/tag/v4.13.1)

CLI: inotia00/revanced-cli-4.6.1-all.jar  
Integrations: inotia00/revanced-integrations-1.13.1.apk  
Patches: inotia00/revanced-patches-4.13.1.jar  
[Changelog](https://github.com/inotia00/revanced-patches/releases/tag/v4.13.1)

CLI: inotia00/revanced-cli-4.6.1-all.jar  
Integrations: inotia00/revanced-integrations-1.13.1.apk  
Patches: inotia00/revanced-patches-4.13.1.jar  
[Changelog](https://github.com/inotia00/revanced-patches/releases/tag/v4.13.1)

CLI: inotia00/revanced-cli-4.6.1-all.jar  
Integrations: inotia00/revanced-integrations-1.13.1.apk  
Patches: inotia00/revanced-patches-4.13.1.jar  
[Changelog](https://github.com/inotia00/revanced-patches/releases/tag/v4.13.1)

CLI: inotia00/revanced-cli-4.6.1-all.jar  
Integrations: inotia00/revanced-integrations-1.13.1.apk  
Patches: inotia00/revanced-patches-4.13.1.jar  
[Changelog](https://github.com/inotia00/revanced-patches/releases/tag/v4.13.1)

CLI: inotia00/revanced-cli-4.6.1-all.jar  
Integrations: inotia00/revanced-integrations-1.13.1.apk  
Patches: inotia00/revanced-patches-4.13.1.jar  
[Changelog](https://github.com/inotia00/revanced-patches/releases/tag/v4.13.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

CLI: j-hc/revanced-cli-4.6.0-all.jar  
Integrations: ReVanced/revanced-integrations-1.14.1.apk  
Patches: ReVanced/revanced-patches-4.14.1.jar  
[Changelog](https://github.com/ReVanced/revanced-patches/releases/tag/v4.14.1)

The duplicates also cause the CI to rebuild even if there's no new version.

j-hc commented 3 weeks ago

should be fine now 998057a