Added optional `mpv_args` argument to types

j-holub / Node-MPV

A NodeJs Module for MPV Player

https://www.npmjs.com/package/node-mpv

MIT License

116 stars 73 forks source link

Added optional `mpv_args` argument to types #101

Closed DavidSingh3 closed 2 years ago

DavidSingh3 commented 2 years ago

Fixes an issue where typescript will complain about providing the mpv_args argument on the Node_MPV.start() method

j-holub commented 2 years ago

Hey there,

sorry I only saw this just now. Is this fix not needed anymore or why did you close it and delete the branch? I'm not very knowledgeable about TypeScript, the ts file was done by someone else.

DavidSingh3 commented 2 years ago

Hi there,

This PR got closed because I renamed my fork's branch that was linked to this Pull Request. I'll open a new PR in just a moment.

I'll provide some basic context as well.