search

j-holub / Node-MPV

A NodeJs Module for MPV Player
https://www.npmjs.com/package/node-mpv
MIT License
116 stars 73 forks source link

update readme #12

Closed pussinboot closed 7 years ago

pussinboot commented 7 years ago

as discussed in #11 plus some minor changes including grammar fixes and changing from the word "song" to "file"

j-holub commented 7 years ago

Thank. I like your *Known Issues text. Sounds good plus it's nice and clean.

Thank you as well for fixing my English :D I do think my English is rather good but I still make mistakes I guess. I'm not a native.

The reason it took me 2 days to reply was that I had to think about the observing part. I actually wanted that section about Observing where all the information was in one place. But with the events right above it, it does indeed seem redundant. After reading your version a couple of times and comparing it to the present one, I'd say I like it. Thanks!

I'm not sure about the file terminology however. I indeed wrote song sometimes and it can also be a video, so this has to be fixed, I agree. But mpv can also load a stream from YouTube, SoundCloud and many other sources (I assume it downloads it through youtube-dl anyway), that's why I think file is not the correct word either. I think I'd just like to keep the terminology to title, like I used it in some places in the README file.

pussinboot commented 7 years ago

hey, no worries about the response time. you're right title is a better term, i've fixed this (i think) with the latest commit. when it can be either a file or a stream i've used the word "title," for loadFile, which only works for local files the word "file" is used. let me know if i missed any, but the readme should be more clear overall now

j-holub commented 7 years ago

That looks perfect. Thank you very much for your help :)

Exams are coming up for me, so I don't know how fast I can get the IPC Thing done, but I'm trying to do my best.