j-holub / Node-MPV

A NodeJs Module for MPV Player
https://www.npmjs.com/package/node-mpv
MIT License
116 stars 73 forks source link

replace 'promise' module by native node Promise() #21

Closed vankasteelj closed 7 years ago

vankasteelj commented 7 years ago

it was actually really simple as you didn't use anything else than new Promise((resolve, reject) => {})

vankasteelj commented 7 years ago

there are still lots of .bind(this) you could probably remove as you use arrow functions, but I don't know if that was intentionnal (not the same this)

j-holub commented 7 years ago

Yep you're right about the bind thing. When I wrote the module I didn't know of the arrow functions yet. In Ver2 I should've removed most of the bind already and replaced it with the arrow functions.

vankasteelj commented 7 years ago

take on those var while you're at it 👍

j-holub commented 7 years ago

Yep had that in my mind for a long time now, too ;) Already removed some on go