search

j-holub / Node-MPV

A NodeJs Module for MPV Player
https://www.npmjs.com/package/node-mpv
MIT License
116 stars 73 forks source link

Rewrite promises #24

Closed vankasteelj closed 7 years ago

vankasteelj commented 7 years ago

Remove unneeded code from promises

j-holub commented 7 years ago

Thanks a lot for this valuable (and for me personal educational) additions

j-holub commented 7 years ago

And thank you really much for the comments to the commits, that helped a lot actually. Really appreciate it

vankasteelj commented 7 years ago

you're welcome. I tried to replace your objects with classes, but couldnt figure out how to extend the main class with events, audio, subtitles and such :(

j-holub commented 7 years ago

Yeah that was also something I was thinking about doing. One obvious solution is of course to put everything into one file. But I think that file would easily span a thousand lines and I'm not very fond of that.