search

j-holub / Node-MPV

A NodeJs Module for MPV Player
https://www.npmjs.com/package/node-mpv
MIT License
116 stars 73 forks source link

Replaced dependency cuid by uuid #43

Closed AxelTerizaki closed 6 years ago

AxelTerizaki commented 6 years ago

Much smaller (85Kb instead of 2.3Mb)

Note : I used v4 (the random one) but v1 (the timestamp version) could be used instead. Feel free to check out the documentation : https://github.com/kelektiv/node-uuid

wopian commented 6 years ago

cuid^1 had a huge footprint, but cuid^2 is available and it has a node_modules footprint of just 25kb.

According to the release notes the API hasn't changed in the major update and now has 0 dependencies.

Edit: Seems the last ^1 patch release was quite the anomaly

AxelTerizaki commented 6 years ago

Oh wow, nice. I didn't think of checking if node-mpv was using the latest cuid. It's even better than uuid then, making my PR useless 👍

All @00SteinsGate00 has to do is update the cuid dependency then.

I could submit another pull request instead then.

j-holub commented 6 years ago

Hey there,

first thanks for taking the time for the PR and thanks @wopian for pointing out the CUID update. I think updating CUID is the better way here. I don't want to be the lazy ass that delegates tasks to others but if you want to, you can form a Pull Request @AxelTerizaki

I'm currently working on finishing the base of Version 2 and it's looking really good so far.

AxelTerizaki commented 6 years ago

Hey, I'm using node-mpv on my project so least I could do is contribute to it a little.

I'll make an other PR with the update later today.