j-holub / Node-MPV

A NodeJs Module for MPV Player
https://www.npmjs.com/package/node-mpv
MIT License
116 stars 73 forks source link

Return options.ipc_command instead of hard coded string #48

Closed kalacs closed 5 years ago

j-holub commented 5 years ago

Hey there,

thanks for taking the time to contribute to the project. However it doesn't make sense to use a not supported argument I think. The warning tells the user that the argument he entered was wrong and it's using the one that is correct since mpv 0.17.0 which will work most likely.

It doesn't make sense to have the function return an invalid ipc command.

Please let me know if you heavily disagree and why.