Closed AxelTerizaki closed 4 years ago
I'm using v2 too, it's working kinda flawlessly (apart from another opened issue here, that you can work around). I'm can't maintain it, but I'd be interested in a publicly released v2 instead of relying on "the latest commit from v2 branch" which isn't saved on NPM and could disapear some day.
Well, if @00SteinsGate00 doesn't show up in a while, I'll probably make a fork and maintain it more actively for people here. I agree relying on commit/branches in package.json causes issues because npm/yarn can't tell if there's been a modification unless we use semver.
I'm going to work on forking this as promised, just give me a bit of time to set things up.
I need to figure out if I'm going to host this on Github as a fork or upload it to my self-hosted Gitlab on http://labs.shelter.moe
Getting it on my gitlab would allow me more freedom and the use of Gitlab's CI/CD but I'm not sure people always enjoy going to other people's gitlabs to contribute and prefer github's centralized community instead...
Feedback would be much appreciated.
I also need to think of a name for this fork :)
Oh and people who wish to actively contribute and maintain along with me are welcome of course.
I plan to get a proper pipeline going for publishing to npm on new releases, as well as rewriting the module in typescript first things first.
I'd much prefer github, and making it as a fork would help readability of your project (and make remerger easy, one day).
The name could be as simple as mpv-wrapper, or mpv-commander, or mpv-link. I dunno. Don't forget to use the MIT license and the copyright from here has to be included though.
Hey there,
Sorry for my late reply, I‘ve been to Japan from January to March and I am currently working on my master thesis.
However I have a lot of not pushed changes which is why it is hard to work on the PR.
I‘m glad that you are using this project and are enjoying it. I would love to continue maintaining it, I just have to sit down and get the stuff I worked on straight and work on the PRs and issues.
I‘ll have a look at it next week if that‘s okay? Pretty busy this weekend and the beginning of next week but after that I can have a look. I ran into some difficulties working on version 2 which made me stop for a while.
Best regards
Yeah! That's great to see you're still here @00SteinsGate00 I was getting worried.
I'll hold on on doing anything then. My offer to be a maintainer for the project still stands though if you're interested.
@vankasteelj problem is I like working with a CI/CD, and I'm used to gitlab's. I don't know which ci/cd options I have on github, and making gitlab's ci/cd (gitlab-runner) work with github means I'd have to use the entreprise version of gitlab
Just to tell you I'm still alive. I've been on a small roadtrip through Austria und South Bavaria the last days and just got home. I got some catching up to do on my Master Thesis, some photos to edit for well something like clients, and the heat wave is killing me, but I didn't forget about this.
I like your offer of helping me maintaining it @AxelTerizaki and I think I will happily accept that offer and I'm looking forward to working with you. I just wanna sort everything we got so far before doing that step. I hope that's fine with you.
I'd like to take the time to rewrite some stuff indeed, provide types for typescript users, use async/await, and stuff like that.
I know about the heat wave, sadly :p (I'm in France)
Take your time, at least we know you're still alive and well.
Good call, I was thinking about providing types for typescript users as well :)
Hello @00SteinsGate00 We really want to see this library grow. At least, we can publish the version 2 to be able to use the Promises.
Thanks!
For those interested, I created a npm package called node-mpv-km. It contains a few fixes (see README).
I don't plan on actively developing it as I'm waiting for @00SteinsGate00 to come back from busy-land, but I needed a npm package with proper semver to include in my project KaraokeMugen
Yeah man Master thesis deadline approaching and master thesis look red like a traffic light... gotto get my shit together and merge your PR and my local changes. Really terribly sorry. I hope we can easily merge node-mv an node-mpv-km hopefully soon without too much hastle.
My bad
@00SteinsGate00 don't stress out and focus on your thesis. I made the package as a temporary solution as I was having problems integrating a github commit link in Karaoke Mugen's package.json because sometimes yarn/npm just did something stupid and pulled an old version from their cache instead of the one I wanted to pull. So now with a semver versioning I won't have these problems anymore.
The package is the same code for node-mpv 2.x plus my two changes, I'm sure we'll be able to merge it and I'll put a discontinued banner on my work on NPM when this happens.
Just wanted to inform everyone in this thread that I'm back at it :)
Hello there, it's me again.
I've seen there has been close to no activity on the project for a bit. Do you need help maintaining the project? I could merge the PRs I made and release version 2 for you and keep it living.
We've been using node-mpv for a while for Karaoke Mugen, and it proved to be quite stable so far. I could even write some more docs with concrete examples of what can be acheived.
Hope everything's going well for you.