j-maly / CommandLineParser

Command line parser. Declarative arguments support. Rich set of argument types (switches, enums, files, etc...). Mutually exclusive arguments validations.
MIT License
137 stars 30 forks source link

v3.0.20 binary is not signed #67

Closed TheSaltyKorean closed 3 years ago

TheSaltyKorean commented 5 years ago

'warning BC41997: Referenced assembly 'CommandLineArgumentsParser, Version=3.0.20.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.'

Not sure what happened but the binary isn't signed again

TheSaltyKorean commented 5 years ago

Looks like the last version that was signed was version 3.0.16

StefH commented 5 years ago

@j-maly It seems the pfx file is password protected, so cannot create a new build. Do you have the password? If so, can you share? Or just create version 3.0.21?

TheSaltyKorean commented 5 years ago

bump ... We should be able to create a new signing file. An snk file will do just fine. The public nature of the file/password is rather meaningless as even Microsoft hopes to do away with signing files. The problem comes in when software publishers like me need signed files in order for applications to work on corporate desktops due to policy restrictions

StefH commented 5 years ago

I can just add a snk file to git and just create a signed dll.

Not 100% secure/preferred but this will work.

alexandre-lecoq commented 5 years ago

If you can add a snk file that would be great. Lot of projects do that : https://github.com/commandlineparser/commandline/blob/master/CommandLine.snk

askids commented 4 years ago

Any plans of addressing this in near term?

StefH commented 4 years ago

Hello @j-maly , is it ok that I create a new signed NuGet with a new snk file?

askids commented 3 years ago

@StefH any plans to publish the new version using new snk file?

StefH commented 3 years ago

Hello @askids, a new version will be added to NuGet shortly.

https://github.com/j-maly/CommandLineParser/pull/72

askids commented 3 years ago

Thank you @StefH