closes #29 - sales analyst can collect merchants that sell the most i…

j-sm-n / black_thursday

Black Thursday is a system that is able to load, parse, search, and execute business intelligence queries against the data from a typical e-commerece business in Ruby.

0 stars 0 forks source link

closes #29 - sales analyst can collect merchants that sell the most i… #99

Closed j-sm-n closed 7 years ago

j-sm-n commented 7 years ago

Open and willing to receive any refactor points or questions with this one. 😄

ALSO ⚠️ ⚠️⚠️ For some reason, my last test in my sales_analyst_test.rb file caused the inspect method (from the spec harness) in our merchant repo to freak out and return nil.

I had to comment it out to get everything to work, but if I comment out my last test, everything runs just fine, so I'm super confused.

jesse-spevack commented 7 years ago

Lets refactor your each.with_index tomorrow. I bet we can do it with reduce alone.