j-tai / TieFix

A Fabric mod that fixes some annoying Minecraft bugs
GNU Lesser General Public License v3.0
17 stars 3 forks source link

Text in settings screen can overlap buttons #16

Open Amirhan-Taipovjan-Greatest-I opened 1 year ago

Amirhan-Taipovjan-Greatest-I commented 1 year ago

First of all, I think that It would be nice if the descriptions of bugs were in the tooltips... because if I want to translate this mod, for example, into Tatar Language... I have a BIG problems with text fitting that cannot be avoided:

image image

I'm not so sure about this one, because I tested v.1.11.0, but I think that nothing changed in newest version: Also, as I can see, there's missing "No", "Yes", "Reset" and "Save & Quit" strings in the file "en_us.json"... You can use an Vanilla-ish translations for "Yes" and "Reset", but "No" and "Save & Quit" strings still need to be added in source translation file.

j-tai commented 1 year ago

Thanks for contributing :)

Yes, this is something that has frustrated me as well. I had to spend some effort to fit the English text in that space, though this isn't an ideal solution, and I recognize that some languages may take more space.

This mod currently uses Cloth Config to generate the configuration screen. I'll have to look into whether Cloth Config can wrap the text. The reason I didn't put the description in the tooltips is because that makes it much slower to find the specific fix you are looking for. People will usually look for options based on the description, not the bug ID.

To translate the No/Yes/Reset/etc. texts, they should be translated in Cloth Config. See here: https://github.com/shedaniel/cloth-config/tree/v8/common/src/main/resources/assets/cloth-config2/lang

Amirhan-Taipovjan-Greatest-I commented 1 year ago

This mod currently uses Cloth Config to generate the configuration screen. I'll have to look into whether Cloth Config can wrap the text. The reason I didn't put the description in the tooltips is because that makes it much slower to find the specific fix you are looking for. People will usually look for options based on the description, not the bug ID.

Yeah, I can agree with You... I just suggested the way that I see as the solution for this issue.

To translate the No/Yes/Reset/etc. texts, they should be translated in Cloth Config. See here: https://github.com/shedaniel/cloth-config/tree/v8/common/src/main/resources/assets/cloth-config2/lang

Unfortunately, this project seems to be abandoned more than 1 month ago... because I saw submission of other translation files and their updates...

j-tai commented 1 year ago

Okay, I took a look at Cloth Config's code, and it appears there is no way to make Cloth Config wrap the text automatically.

I could try to add line wrapping on TieFix's side, though...

For now, you can continue translating if you like, and I'll figure out how to make the text fit.

Unfortunately, this project seems to be abandoned more than 1 month ago... because I saw submission of other translation files and their updates...

I would recommend that you submit a PR anyway. It's likely that the author(s) will come back and update it once the next Minecraft version releases.

Amirhan-Taipovjan-Greatest-I commented 1 year ago

For now, you can continue translating if you like, and I'll figure out how to make the text fit.

I think I should wait for new patch, where You figure out how to make text fit... because the changes can be cardinal...

I would recommend that you submit a PR anyway. It's likely that the author(s) will come back and update it once the next Minecraft version releases.

Yeah, I submitted it right now... I hope, that I and Kazakh colleague won't be ignored =)

j-tai commented 1 year ago

If you're done translating, you can just submit the PR and ignore the text overlapping the buttons. I will see if I can figure out a way to wrap the text. When I do that, you won't need to update the translation again.

Amirhan-Taipovjan-Greatest-I commented 1 year ago

Ok, then check this PR -> #18