search

j-vanetten / openpilot

jvePilot: FCA: Hybrid OpenPilot/ACC
55 stars 29 forks source link

Add IP Address to sidebar #7

Closed TheWizard1328 closed 3 years ago

TheWizard1328 commented 3 years ago
TheWizard1328 commented 3 years ago

So this would be a no go for addition then???

Wizard Worxx Where the magic of software begins. Robert Tauber (780) 236-1542<tel:(780)%20236-1542> www.Facebook.com/WizardWorxx13http://www.facebook.com/WizardWorxx13

From: John Van Etten @.> Sent: Sunday, May 30, 2021 5:18:09 PM To: j-vanetten/openpilot @.> Cc: TheWizard1328 @.>; Author @.> Subject: Re: [j-vanetten/openpilot] Add IP Address to sidebar (#7)

@j-vanetten commented on this pull request.

In selfdrive/ui/qt/sidebar.cchttps://github.com/j-vanetten/openpilot/pull/7#discussion_r642142037:

p.drawText(r, Qt::AlignCenter, network_type[net_type]);

  • // Future line for current IP Address
  • //configFont(p, "Open Sans", 28, "Regular");
  • //const QRect s = QRect(30, 260, 240, 50);
  • //p.drawText(s, Qt::AlignCenter, "000.000.000.000");

Arnepilot has the IP address sent from python. https://github.com/arne182/ArnePilot/blob/8ed7b03f43d6def9179c862f657498ccaffa5329/selfdrive/ui/sidebar.cc#L67

I'm not sure there is going to be an easy way to get this. From what I can tell, you'll have to run a shell command to dump the IP address, capture/parse the output and then send it to the UI using the pub/sub messages.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/j-vanetten/openpilot/pull/7#pullrequestreview-671873530, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFQGAEH2URQEQ537RSSWYXDTQLBTDANCNFSM45VBRQXA.

j-vanetten commented 3 years ago

@TheWizard1328 I personally don't need it so I don't find it useful. It seems like a lot of overhead just to show the IP address.

debugged-tech commented 3 years ago

It's nice to have, but there are other ways to get the IP address and they are not that difficult. Only us dev's usually need to make changes after installed anyway, IMO 🤷🏻‍♂️

TheWizard1328 commented 3 years ago

I guess so.

Wizard Worxx Where the magic of software begins. Robert Tauber (780) 236-1542<tel:(780)%20236-1542> www.Facebook.com/WizardWorxx13http://www.facebook.com/WizardWorxx13

From: John Van Etten @.> Sent: Saturday, June 12, 2021 1:51:38 PM To: j-vanetten/openpilot @.> Cc: TheWizard1328 @.>; Mention @.> Subject: Re: [j-vanetten/openpilot] Add IP Address to sidebar (#7)

Closed #7https://github.com/j-vanetten/openpilot/pull/7.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/j-vanetten/openpilot/pull/7#event-4881611426, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFQGAEAFL4GP7E4SWD5KVH3TSO3EVANCNFSM45VBRQXA.

j-vanetten commented 3 years ago

While I see the convenience, It's not a complete PR and I think it's just not useful enough to have to maintain. I do have to keep up with merges from comma's repo and the more changes I add the harder it will be to keep up.

TheWizard1328 commented 3 years ago

Understandable

Wizard Worxx Where the magic of software begins. Robert Tauber (780) 236-1542<tel:(780)%20236-1542> www.Facebook.com/WizardWorxx13http://www.facebook.com/WizardWorxx13

From: John Van Etten @.> Sent: Saturday, June 12, 2021 2:09:27 PM To: j-vanetten/openpilot @.> Cc: TheWizard1328 @.>; Mention @.> Subject: Re: [j-vanetten/openpilot] Add IP Address to sidebar (#7)

While I see the convenience, It's not a complete PR and I think it's just not useful enough to have to maintain. I do have to keep up with merges from comma's repo and the more changes I add the harder it will be to keep up.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/j-vanetten/openpilot/pull/7#issuecomment-860102918, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFQGAEE6TQNBXXTLXTFUEYDTSO5HPANCNFSM45VBRQXA.