search

j0ack / discirc

mirrored from https://git.joakode.fr/joack/discirc
http://docs.joakode.fr/discirc/
GNU General Public License v3.0
9 stars 8 forks source link

Wait for MOTD before joining channels in irc bot #10

Closed tmarki closed 6 years ago

tmarki commented 6 years ago

Hello,

your version does not work for the MOTD message, so on some IRC servers it fails to join any channels.

I fixed this by adding a callback for this, I hope you can merge it.

Thanks, Tamas

tmarki commented 6 years ago

Added the docstring, I hope it's descriptive enough!

TeoTwawki commented 6 years ago

@tmarki if I may make a suggestion:

    """checking if Message Of The Day is done because it may interfere with joining channels"""
    def on_motddone(self, message):

Future editors then know both why clients should wait and what motd is when they read the comment.

j0ack was concerned ppl wouldn't know what motd is.

j0ack commented 6 years ago

I agree with @TeoTwawki, people may not know what MOTD stands for.

Just a little description as suggested would be great.

tmarki commented 6 years ago

I replaced the docstring with your version.

j0ack commented 6 years ago

Put the docstring behind the def and it will be fine for me.

Thanks for the work :)

tmarki commented 6 years ago

Done!