search

j0ack / discirc

mirrored from https://git.joakode.fr/joack/discirc
http://docs.joakode.fr/discirc/
GNU General Public License v3.0
9 stars 8 forks source link

PASS violates RFC and doesn't work #24

Open Cheaterman opened 3 years ago

Cheaterman commented 3 years ago

https://github.com/j0ack/discirc/blob/master/discirc/irc_bot.py#L75

This violates the RFC and therefore doesn't work.

A "PASS" command is not required for either client or server connection to be registered, but it must precede the server message or the latter of the NICK/USER combination

Reordering these lines properly does work. :-)

j0ack commented 3 years ago

I remember encounter some errors for servers needing PASS but I can't remember which. Can you submit a PR resolving this issue ?

TeoTwawki commented 3 years ago

I remember encounter some errors for servers needing PASS but I can't remember which.

Rizon network iirc back then. Dunno if its still the case. I knew they violated spec but it didn't seem to bother freenode to do things "wrong" (in order for rizon to work) back then.

My team has since stopped using irc and since my bouncer got kicked, I no longer had an interest in keeping a bridge going.