search

j0ack / discirc

mirrored from https://git.joakode.fr/joack/discirc
http://docs.joakode.fr/discirc/
GNU General Public License v3.0
9 stars 8 forks source link

Add support for password protected IRC channels #7

Closed TeoTwawki closed 7 years ago

TeoTwawki commented 7 years ago

Tested on freenode.

Rizon keeps being uncooperative, so I had to go elsewhere.

j0ack commented 7 years ago

Thank you for the PR, I make some comments on your code.

j0ack commented 7 years ago

Are you still interested in this PR or should I implement my comments ?

TeoTwawki commented 7 years ago

If you wanted something changed or there was a problem with it, you never actually told me so. The reply I received said only you intended to make some comments on my code. I assumed that meant you were reviewing it.

j0ack commented 7 years ago

I actually did some comments in your code please tell me if you can't see it. It seems that I didn't submit it my bad.

TeoTwawki commented 7 years ago

Amended but dunno if I got it right.

TeoTwawki commented 7 years ago

fix'd