search

j0be / PowerDeleteSuite

Power Delete Suite for Reddit
1.57k stars 97 forks source link

Fix comment hashtag issue #38

Closed biran4454 closed 1 year ago

biran4454 commented 1 year ago

Fix hashtags from ending the file too early. Closes #34 and possibly #20.

biran4454 commented 1 year ago

I considered replacing # with a hyphen or other symbol, however I opted for removing the hashtag entirely since I felt it was unlikely to cause too much of an issue.
In retrospect however it may interfere with the MD syntax for headings and python comments, let me know what you think.

j0be commented 1 year ago

Replace it with "%23" and I'll get that merged

j0be commented 1 year ago

That bug is actually caused because it's a part of an href, which makes it parsed as a URL. Technically, PDS should really run encodeURIComponent() on every comment value, but this at least fixes hashes

biran4454 commented 1 year ago

Replace it with "%23" and I'll get that merged

Done! Not sure why I didn't do this in the first place haha.