j0hnsmith / django-pipeline-browserify

MIT License
37 stars 18 forks source link

Overhaul commands handling and make settings handling consistent #18

Closed natevw closed 7 years ago

natevw commented 7 years ago

The fix for #15 turned out to be fairly involved. I think the is_outdated pull request that's been incorporated into 0.4.1 must have been quite stale, since it not only used different BROWSERIFY settings but also relied on SubProcessCompiler.execute_command behavior that got changed in django-pipeline over a year ago now: https://github.com/jazzband/django-pipeline/commit/1f6b48ae74026a12f955f2f15f9f08823d744515

I ended up basically overhauling this library, sorry 😬

Apologies that this ended up being such a major and invasive change, but hope it's a valuable contribution nonetheless!

j0hnsmith commented 7 years ago

@natevw I haven't used browserify for years and don't even have a dev env for this repo, can I add you as a collaborator to this repo?

natevw commented 7 years ago

@j0hnsmith Sure, I don't mind. What's the process for releasing on PyPi?

j0hnsmith commented 7 years ago

What's the process for releasing on PyPi?

Just bump the version and run a couple of setuptools (or something?) commands, I'll figure it out at the weekend (or before if I get a chance).

natevw commented 7 years ago

Friendly reminder that it'd be great to have these recent changes released at least in beta form. They've been Working on My Machineâ„¢ this week at least.

j0hnsmith commented 7 years ago

done

natevw commented 7 years ago

@j0hnsmith I see this and #19 were published as django-pipeline-browserify==0.6.0, thanks!