search

j0j00 / flutter_user_agent

Retrieve Android/iOS device user agents in Flutter.
https://pub.dev/packages/flutter_user_agent
BSD 2-Clause "Simplified" License
25 stars 56 forks source link

Update android compileSdkVersion to 28 #5

Closed guersam closed 4 years ago

guersam commented 4 years ago

To resolve build error when R8 is enabled.

https://github.com/flutter/flutter/issues/27226#issuecomment-458574164

j0j00 commented 4 years ago

Thanks, do you mind updating the PR to do a full AndroidX integration? Example of this being done is available here.

Once you test to confirm that it doesn't break anything, I can publish the update up.

guersam commented 4 years ago

I'm willing to, but it won't be anytime soon due to lack of time :( Thanks for the response with a detailed example BTW!

miguelpruivo commented 4 years ago

Please merge this ASAP so we don't have to use a fork reference for a customer app.

adrianvintu commented 4 years ago

my fix, here https://github.com/adee42/flutter_keyboard_visibility/issues/42#issuecomment-566656630

guersam commented 4 years ago

Superseded by #8. Thanks, @yousifk!