Update And Test new version Flutter

yousifk commented 4 years ago

merge with androidx and update to 28 SDK

yousifk commented 4 years ago

it takes a long time, why? @j0j00

miguelcmedeiros commented 4 years ago

It would be really great to get a new version with this PR included, otherwise we can’t use it with flutter 1.12.13. Looking forward to it 🙂

rodruiz commented 4 years ago

I'm using flutter_user_agent: ^1.2.1 with flutter v1.12.13+hotfix.5 and no issues so far. You can update the following in your own project:

File: PROJECT-DIR/android/gradle.properties

org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true
android.enableJetifier=true
android.enableR8=true

File: PROJECT-DIR/android/build.gradle

...
dependencies {
    classpath 'com.android.tools.build:gradle:3.5.3'
}

File: PROJECT-DIR/android/app/build.gradle

...
android {
    compileSdkVersion 29

....

    defaultConfig {
        minSdkVersion 21
        targetSdkVersion 29
        multiDexEnabled true
        versionCode flutterVersionCode.toInteger()
        versionName flutterVersionName
        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
    }
....
}

j0j00 commented 4 years ago

Sorry @yousifk, I've been having PC problems so can't do anything at the moment. You should be able to work around it locally by targeting your fork in the pubspec.yml.

I think your code changes before the examples one were fine. The new one commits certain files which I don't think should be in version control, especially the ones which reference your local directory structure.

j0j00 commented 4 years ago

Closing the PR for now until it's updated.

j0j00 / flutter_user_agent

Update And Test new version Flutter #8