search

j0k3r / graby-site-config

Graby site config files
Other
18 stars 29 forks source link

Sanitize more of the embed iframe from youtube #41

Closed mostfunkyduck closed 3 years ago

mostfunkyduck commented 3 years ago

Currently, when you try to scrape a youtube video with this via wallabag, the presence of url encoded quotes in the value of the iframe's src property is corrupting the rendered link. An extra https://www.youtube.com%20 is being inserted in said property at some point in the process. This can be reproduced by having wallabag try to archive any youtube video (such as the one in this site config).

This change will make it so that the url encoded quotes are replaced with ASCII quotes, which is fixing the problem on my end. I'm not sure if the behavior I'm seeing implies another bug somewhere in this process, or if I should be looking at another project, but as the intent of the site config appears to be to parse the iframe as if it were HTML, this seems like a needed fix either way.

Please push your site_config changes at fivefilters/ftr-site-config instead. I regularly merge the upstream in that repo (so you don't need to duplicate your effort).

j0k3r commented 3 years ago

Thanks for that, but as stated in the PR template (and you left it in your comment):

Please push your site_config changes at fivefilters/ftr-site-config instead. I regularly merge the upstream in that repo (so you don't need to duplicate your effort).

mostfunkyduck commented 3 years ago

ha! missed that, sorry.