search

j0k3r / graby

Graby helps you extract article content from web pages
MIT License
367 stars 74 forks source link

Switch to official tcpdf #169

Closed j0k3r closed 6 years ago

j0k3r commented 6 years ago

https://nvd.nist.gov/vuln/detail/CVE-2018-17057

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.361% when pulling 024efbe32a9ca67bf1d81bf1a4b652f327fa7c27 on tcpdf into f419f8eb4addb2384d0203b3b9b0114dd3f312af on master.

jtojnar commented 6 years ago

Why not update our fork?

j0k3r commented 6 years ago

I just updated our fork and I see that we don't have much difference: https://github.com/tecnickcom/TCPDF/compare/master...wallabag:master

The only difference is related $maxchwidth but the way we fixed it isn't really a fix because the variable won't be declared after and might (also) generate a warning later.

I don't know if the bug still exist in the official repo. We should check with https://github.com/wallabag/wallabag/issues/2776

j0k3r commented 6 years ago

I've updated our fork, we'll see later to make the change.