search

j0k3r / graby

Graby helps you extract article content from web pages
MIT License
363 stars 73 forks source link

Logger infos added for JsonLd parsing #203

Closed Simounet closed 5 years ago

Simounet commented 5 years ago

Hi there, I added some info from the logger to get debug on JsonLd parsing. Have a nice day.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.01%) to 97.803% when pulling e2314b685c63331494023fd8768c72b15507ed5c on Simounet:feat/jsonld-logger-infos into c7fcea010a6a09f6505b7be0d825ac78801cd831 on j0k3r:master.

j0k3r commented 5 years ago

You should update tests too

Simounet commented 5 years ago

Hmm, I'm kind of lost. I've just added logger infos. What do you want me to test?

jtojnar commented 5 years ago

Some tests check the log output so you might need to update them.

But first you should fix the undefined member access:

Undefined property: Graby\Extractor\ContentExtractor::$author
/home/travis/build/j0k3r/graby/src/Extractor/ContentExtractor.php:1204
/home/travis/build/j0k3r/graby/src/Extractor/ContentExtractor.php:313
/home/travis/build/j0k3r/graby/src/Graby.php:345
/home/travis/build/j0k3r/graby/src/Graby.php:168
/home/travis/build/j0k3r/graby/tests/GrabyTest.php:1617
Simounet commented 5 years ago

I fixed it. Sorry for that.