Closed shtrom closed 2 years ago
@j0k3r, ok, fixed, added tests, and squashed. I have a failing integration test, but it's also on master
:
1) Tests\Graby\GrabyFunctionalTest::testMultipage
Failed asserting that 'Radeon HD 7750/7770 : DirectX 11.1 & PCI-Express 3.0 accessibles ? Participez aux discussions Recevez des notifications Profitez du mode sombre Vous avez déjà un compte ? Connectez-vous Utilisateur Mot de passe J'ai oublié mon mot de passe 0 0 Clubic …' contains "Avec un peu de retard sur le planning".
/home/shtrom/src/graby/tests/GrabyFunctionalTest.php:301
FAILURES!
Tests: 231, Assertions: 1033, Failures: 1, Skipped: 1.
I'm now giving that a spin in wallabag (;
I'm now giving that a spin in wallabag (;
Works like a charm :ok_hand:
I hope it gets into 2.4 :wink:
@j0k3r do you think there are more changes needed?
@j0k3r do you think there is anything blocking this getting merged?
I'm so sorry for the too long delay about your PR @shtrom ... I've rebased it against the master, fixed conflicts and linter issues.
Heh, no worries. Glad it's in!
@j0k3r early WIP on #198, but keen to hear your thoughts.