Replace string before redirect

shtrom commented 5 years ago

@j0k3r early WIP on #198, but keen to hear your thoughts.

shtrom commented 5 years ago

@j0k3r, ok, fixed, added tests, and squashed. I have a failing integration test, but it's also on master:

1) Tests\Graby\GrabyFunctionalTest::testMultipage
Failed asserting that 'Radeon HD 7750/7770 : DirectX 11.1 &amp; PCI-Express 3.0 accessibles ? Participez aux discussions Recevez des notifications Profitez du mode sombre Vous avez déjà un compte ? Connectez-vous Utilisateur Mot de passe J'ai oublié mon mot de passe 0 0 Clubic &hellip;' contains "Avec un peu de retard sur le planning".

/home/shtrom/src/graby/tests/GrabyFunctionalTest.php:301

FAILURES!
Tests: 231, Assertions: 1033, Failures: 1, Skipped: 1.

I'm now giving that a spin in wallabag (;

shtrom commented 5 years ago

I'm now giving that a spin in wallabag (;

Works like a charm :ok_hand:

I hope it gets into 2.4 :wink:

shtrom commented 4 years ago

@j0k3r do you think there are more changes needed?

shtrom commented 3 years ago

@j0k3r do you think there is anything blocking this getting merged?

j0k3r commented 2 years ago

I'm so sorry for the too long delay about your PR @shtrom ... I've rebased it against the master, fixed conflicts and linter issues.

coveralls commented 2 years ago

Coverage increased (+0.03%) to 95.077% when pulling 515b69cb12a806a4dabc3b00baa55c1bcae03b4f on shtrom:replace_string-before-redirect into abe816a7708d3cffd86135d70572119ece43d7b6 on j0k3r:master.

shtrom commented 2 years ago

Heh, no worries. Glad it's in!

j0k3r / graby

Replace string before redirect #212