Lock to PHPUnit 7 - Githubissues

j0k3r / graby

Graby helps you extract article content from web pages

MIT License

365 stars 74 forks source link

Lock to PHPUnit 7 #220

Closed j0k3r closed 4 years ago

j0k3r commented 4 years ago

PHPUnit 8 require PHP >= 7.2 Graby require PHP >= 7.1

coveralls commented 4 years ago

Coverage increased (+0.005%) to 96.541% when pulling 436826e9ac430442995ca28c9a6fe6dd0c5698ce on fix/phpunit into 8dcacf79bd2bc18438dc3c93cdee1fa59f9a848b on master.

Kdecherf commented 4 years ago

As PHP 7.1 reached EOL a few weeks ago, could we define a date for sunsetting its support in Graby?

tcitworld commented 4 years ago

After wallabag 2.4 release? :p

jtojnar commented 4 years ago

The fact that php.net no longer supports a certain release is not relevant for many people, as they often use their distribution’s fork of PHP, which has security issues fixed by e.g. RedHat. As before, I would suggest creating a new major branch when dropping old versions of PHP, so that selfoss can switch to that (we target PHP used by supported Debian versions.