Fix and refactor makeAbsoluteStr

j0k3r / graby

Graby helps you extract article content from web pages

MIT License

363 stars 73 forks source link

Fix and refactor makeAbsoluteStr #249

Closed Kdecherf closed 3 years ago

Kdecherf commented 3 years ago

This commit achieves several things:

Remove str_replace() as removing the path from the base misleads the resolver, e.g. makeAbsoluteStr(http://example.org/?d=hello,img.jpg) actually leads to http:img.jpg instead of http://example.org/img.jpg
Refactor the whole method to simplify it and rely more on Uri
Update the test with path containing leading double slashes as we should keep the same behavior than browsers

coveralls commented 3 years ago

Coverage remained the same at 96.456% when pulling 33e6758fbd253163e792753bf976b35fee106b67 on Kdecherf:fix/absoluteStr into 987aa6cb4d548492f27a2552e6c7f1193bde0ccf on j0k3r:master.