search

j0k3r / graby

Graby helps you extract article content from web pages
MIT License
363 stars 73 forks source link

HttpClient: refactor the way we clean utm_ query params #252

Closed Kdecherf closed 2 years ago

Kdecherf commented 3 years ago

The old preg_replace call incorrectly removed the ? of the query string section which could lead to things like this:

http://example.com/foo?utm_source=a&var=value => http://example.com/foo&var=value

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.01%) to 95.315% when pulling 8bcef771099f4d365c9d15a5a5fb2221d37bc330 on Kdecherf:fix/utm-query into 1e06a555e33ab51adeb71cbe27135b9233425e2f on j0k3r:master.

j0k3r commented 2 years ago

Sh*t I fucked up the PR when changing the base branch and then merged it 🤦‍♂️ Could you reopen the same PR targeting the 2.x branch without my latest changes from the upcoming 3.0? So your PR will be part of the next 2.x release and also 3.0. Thanks and sorry for the extra work..