Case where an attribute is empty overriding a filled in value

j0k3r / graby

Graby helps you extract article content from web pages

MIT License

363 stars 73 forks source link

Case where an attribute is empty overriding a filled in value #255

Closed Simounet closed 3 years ago

Simounet commented 3 years ago

Hi there, Fix a case where an empty attribute were overriding a filled in one. Have a nice day and stay safe.

Simounet commented 3 years ago

I removed the assert verifying the language attribute is null because it's what I want to avoid. Using an empty attribute is not helpful, is it?

coveralls commented 3 years ago

Coverage increased (+0.003%) to 96.498% when pulling 08c1ae5f1c07b7d73c7ffc0753e45804c39a45c8 on Simounet:feat/empty-srcset into bf02bc50033cfbb10718ea3f5a62fc0fd6426e5b on j0k3r:master.

Simounet commented 3 years ago

Sorry. It's an issue with the master branch not from my PR. I'm trying to fix it anyway.

j0k3r commented 3 years ago

Thanks!