Closed jtojnar closed 2 years ago
Maybe you can separate the code improvement (fn
, ??
, etc.) in a separate PR to reduce the noise?
I can separate them out but then CI will not pass. It should still be feasible to review commit by commit.
Or I can move the ci commit to the new PR too.
Removed the ci part for now.
Still need to replace file_get_contents
with actual fetchContent
and capture the resources.
I got nerd sniped quite hard by this but I had this on to-do list for few other projects. Now running composer rector
should automatically add fixtures for fetchContent
calls on Graby
constructed without a second argument.
Rector is a tool for automated code transformation. The transformation rule runs Graby and extract headers using RecordingHttpClient
will also update the functional tests – the last commit is fully produced by the transformation rule without any manual changes.
If you check out the PR, you can try it yourself by removing the last commit and running composer rector
. (Comment out this line if you do not want the code modernization.)
Can you rebase against the master? And it'll be good to merge
Good job @jtojnar 👊
Use
composer rector
(orcomposer rector -- --dry-run
) to run the automated refactoring.