search

j0k3r / graby

Graby helps you extract article content from web pages
MIT License
365 stars 74 forks source link

Fix back anchor link #327

Closed j0k3r closed 1 year ago

j0k3r commented 1 year ago

Also, use Psr18ClientDiscovery instead HttpClientDiscovery (as reported by PHPStan), see https://docs.php-http.org/en/latest/discovery.html#psr-18-client-discovery

Fix https://github.com/wallabag/wallabag/issues/5315

github-actions[bot] commented 1 year ago

Coverage Status

Coverage: 94.682% (-0.1%) from 94.802% when pulling 1ec24f2fcd0b6bf0a2c988b59cbb9379b6303a78 on fix/anchor-links into d7e117e0243f25033f8dd12ddee20c6d010c1e9c on master.

jtojnar commented 1 year ago

Would be nice to include the context from the Wallabag issue in the commit message. (At least that it was originally introduced in https://github.com/j0k3r/graby/commit/ad87368dc6eab4c13814f05b072e1a2904c82444 and probably accidentally reverted in a merge commit.)

j0k3r commented 1 year ago

I thought linking the wallabag issue in the PR was enough (as it contains the context)

jtojnar commented 1 year ago

It is not in the commit message so it means when doing git blame or git bisect, I would need to open the commit on GitHub, then open the associated PR, then open Wallabag issue, and then click the commit. And that is assuming GitHub will still be there in a few years.