search

j0k3r / graby

Graby helps you extract article content from web pages
MIT License
365 stars 74 forks source link

feat: upgrade monolog/monolog to v3 #332

Open kolaente opened 1 year ago

kolaente commented 1 year ago

Resolves https://github.com/j0k3r/graby/issues/331

This probably needs some more fixing. I've added the nix flake to be able to run composer et al, can remove it if you don't need it.

I had to upgrade j0k3r/php-readability to dev-master because monolog now requires psr/log in at least version 3 and the last release only supports v1. As such, this is probably not mergable right now because we now have a dependency on master from that package which will give users something different every time. If you release a new version of that package, I'll happily pin it to that release version.

As per monolog's release docs, the minimum required php version is now 8.1 so I upgraded that as well. I think I migrated all uses of it but I'm not 100% sure. This probably needs more testing from someone who knows how that feature works.

kolaente commented 1 year ago

I guess the tests need an update because we now need 8.1. Should I change them? This probably has other implications I'm not aware of.

jtojnar commented 1 year ago

I am afraid raising minimum PHP version at this time is not in line with for Graby primary consumers. Both Wallabag and selfoss still target PHP 7.4. And while I am open to potentially raising it in selfoss, I would still want to support PHP 8.0 at least until it no longer has upstream security support.

kolaente commented 1 year ago

Yeah that makes sense. Given that php 8.0 will be eol in November, should I pick this up again at that time?

jtojnar commented 1 year ago

If you are willing to implement it, supporting Monolog ^2.4||^3.0 in master is probably the best solution to make Graby usable with project that require 3.0 now.

I would not bet on dropping PHP 8.0 support in November. There are still distros where PHP 8.0 or even 7.4 will be supported for the next while. For example, Debian 11, which ships PHP 7.4, will continue to receive security updates for three more years.

kolaente commented 1 year ago

If you are willing to implement it, supporting Monolog ^2.4||^3.0 in master is probably the best solution to make Graby usable with project that require 3.0 now.

Done

kolaente commented 1 year ago

Now the tests fail with the same issue as in https://github.com/j0k3r/graby/issues/333