Question for wrap_in()

[HolgerAusB]

Question to wrap_in(), from here: https://github.com/j0k3r/graby/pull/262

I love it! @Kdecherf is there a reason, why wrapping is only allowed with blockquote, p and div? Or did I just read the code wrong? Could also be helpful for any other tag-pair like b, strong, em, h2 and even foobar. So if this is done before most other things, I could strip or string_replace 'foobar'. Which currently is sometimes difficult because of auto-stripping span-tags in wallabag.

@fivefilters could we please have this COOOOL feature for FTR and P2K, too?

I used it here:

• https://github.com/HolgerAusB/ftr-site-config/blob/master/developer.mozilla.org.txt
• https://github.com/HolgerAusB/ftr-site-config/blob/master/chat.openai.com.txt

[Kdecherf]

Hello @HolgerAusB,

I've put an allow-list in order to respect HTML semantic usage: blockquote, p and div are allowing flow content tags whereas b, strong and others only accept phrasing content tags, see:

• https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote#technical_summary
• https://developer.mozilla.org/en-US/docs/Web/HTML/Element/strong#technical_summary

[HolgerAusB]

@Kdecherf Understood. We can't set attributes for the wrap, can we? Like class, id, style... ok, last one would be nasty, I know.

[HolgerAusB]

@Kdecherf another idea would be to have a new wrap_text_in(<tag>): <xpath> where only the found text() within matching xpath could be wrapped in <strong>, <em>, <h2> or many others.

Example

source:

<div class="foobar bold column stress">
    <p>
        Lorem ipsum dolor sit amet, consectetur adipisici elit...
    </p>
</div>

site-config:

wrap_text_in(em): //div[contains(@class, 'stress')]
wrap_text_in(strong): //div[contains(@class, 'bold')]

results in:

<div class="foobar bold column stress">
    <p>
        <em>
            <strong>
                Lorem ipsum dolor sit amet, consectetur adipisici elit...
            </strong>
        </em>
    </p>
</div>