j0k3r / graby

Graby helps you extract article content from web pages
MIT License
365 stars 74 forks source link

Optional Parameters can only come after required in PHP 8 #344

Closed tacman closed 6 months ago

tacman commented 6 months ago

Using php 8.3 throws these deprecations:

Deprecated: Optional parameter $node declared before required parameter $logMessage is implicitly treated as a required parameter in /home/tac/g/tacman/f43.me/vendor/j0k3r/graby/src/Extractor/ContentExtractor.php on line 890

Deprecated: Optional parameter $node declared before required parameter $logMessage is implicitly treated as a required parameter in /home/tac/g/tacman/f43.me/vendor/j0k3r/graby/src/Extractor/ContentExtractor.php on line 914

Deprecated: Optional parameter $node declared before required parameter $type is implicitly treated as a required parameter in /home/tac/g/tacman/f43.me/vendor/j0k3r/graby/src/Extractor/ContentExtractor.php on line 985