search

j0k3r / graby

Graby helps you extract article content from web pages
MIT License
362 stars 73 forks source link

Add default values for parameters after optional parameters #345

Closed tacman closed 4 months ago

tacman commented 4 months ago

Fixes #344

Not sure that $type can be null, but this at least gets rid of the deprecation errors.

tacman commented 4 months ago

Makes sense. Should I close this PR and submit a new one with $node as a required parameter?

jtojnar commented 4 months ago

Feel free to force push here

On Fri, 15 Mar 2024, 16:45 Tac Tacelosky, @.***> wrote:

Makes sense. Should I close this PR and submit a new one with $node as a required parameter?

— Reply to this email directly, view it on GitHub https://github.com/j0k3r/graby/pull/345#issuecomment-1999943268, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMEYZIBIPOUKQIE6CJFNDYYMJSDAVCNFSM6AAAAABEYDBAV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZHE2DGMRWHA . You are receiving this because you commented.Message ID: @.***>

jtojnar commented 4 months ago

Superseded by https://github.com/j0k3r/graby/pull/347