search

j0k3r / graby

Graby helps you extract article content from web pages
MIT License
362 stars 73 forks source link

ContentExtractor: Make $node a required parameter #347

Closed tacman closed 4 months ago

tacman commented 4 months ago

Fixes #344

jtojnar commented 4 months ago

Could you please also update the other methods like extractAuthor for consistency?

tacman commented 4 months ago

My logic was to do as little as possible to fix the error. And unfortunately, I'm not that good with PRs like this! Can you accept these, then I'll do a new PR?

And I guess I should close my other ones, although I don't know how this passes PHP 8.3 which is why I added it to the matrix.

coveralls commented 4 months ago

Coverage Status

coverage: 94.897%. remained the same when pulling 1281bf3d7045d2f2682d1af6ba3715e492184e9a on tacman:patch-4 into b720a8c9dbc10a5f6d4443318b71786e7896af6a on j0k3r:master.

jtojnar commented 4 months ago

Yes, generally, a focused patch is best, though it should not break other aspects of the code, be it formal ones (e.g. coding style) or informal (e.g. consistency).

I have added a fix for the extractAuthor case.

Thanks for your contribution.