search

j123b567 / scpi-parser

Open Source SCPI device library
BSD 2-Clause "Simplified" License
447 stars 191 forks source link

Update register implementation #113

Closed PolyPik closed 4 years ago

PolyPik commented 4 years ago

This PR both removes the recursive function calls in SCPI_RegSet and allows library users to add their own device-specific registers to the parser.

PolyPik commented 4 years ago

@j123b567 Basically this PR closes this TODO and #81.

j123b567 commented 4 years ago

Thank you, I will investigate this PR. I must also verify this against SCPI-99, because this PR seems OK, but sometimes SCPI see it differently. So, just to be sure.

Just a hint for further contributions, please create separate branch for each PR. All your new commits to your master will go into this PR automatically, which could be unintentional.

PolyPik commented 4 years ago

Is it good?

PolyPik commented 4 years ago

@j123b567 Is there an ETA?

PolyPik commented 4 years ago

I'm going to make an identical PR using a non-master branch.