search

j123b567 / scpi-parser

Open Source SCPI device library
BSD 2-Clause "Simplified" License
463 stars 194 forks source link

Newtypes #61

Closed jeras closed 8 years ago

jeras commented 8 years ago

In the first commit I have fixed a couple of wrong casts in my code. You can cherry pick only this one.

The second commit, which you can skip, is for a casting issue I have with my code, it might be an issue in the cross compilation toolchain, since I was not able to reproduce it with scpi-parser unit tests on native ARM or x86 platforms.

But there is a different failure while running tests on ARM, which is not present on x86. The report is provided below.

     CUnit - A unit testing framework for C - Version 2.1-2
     http://cunit.sourceforge.net/

Suite: Parser
  Test: SCPI_ParamInt32 ...passed
  Test: SCPI_ParamUInt32 ...passed
  Test: SCPI_ParamInt64 ...FAILED
    1. test/test_parser.c:429  - CU_ASSERT_EQUAL(value,9223372036854775807LL)
    2. test/test_parser.c:430  - CU_ASSERT_EQUAL(value,-9223372036854775807LL)
  Test: SCPI_ParamUInt64 ...passed
  Test: SCPI_ParamFloat ...passed
  Test: SCPI_ParamDouble ...passed
  Test: SCPI_ParamCharacters ...passed
  Test: SCPI_ParamCopyText ...passed
  Test: Commands handling ...passed
  Test: Error handling ...passed
  Test: IEEE 488.2 Mandatory commands ...passed
  Test: Numeric list ...passed
  Test: Channel list ...passed

Run Summary:    Type  Total    Ran Passed Failed Inactive
              suites      1      1    n/a      0        0
               tests     13     13     12      1        0
             asserts    432    432    430      2      n/a
j123b567 commented 8 years ago

There was an error in conversion function. Also reproducable with 32bit build. CFLAGS="-m32" LDFLAGS="-m32" make clean test