search

j143 / systemds-website

Apache SystemDS website source
Apache License 2.0
0 stars 0 forks source link

Adding notebook page to the SystemDS Website #8

Open rebeccadias opened 4 years ago

rebeccadias commented 4 years ago

Adding notebook.html

j143 commented 4 years ago

Notifying the people you would like it to review via email or @ mentions! can help them find this issue.

j143 commented 4 years ago

Now, we need to build notebook.html by passing in the content.

  1. For example, layout: page in page provides the complete layout with content as downloads.html. After the gulp, one might find the _site/downloads.html file with completely rendered html page. image

  2. The same needs to be done for the notebooks too.

    • It can go like this: layout: notebook. with file ./notebook-1.html contains only the notebook code.
    • And When you run gulp this should be rendered to _site/notebook-1.html.

This completest the task.

Thank you. :)

rebeccadias commented 4 years ago

Okay sure Got it thanks! 👍

rebeccadias commented 4 years ago

image

rebeccadias commented 4 years ago

@j143 I have done the things you asked me to do . Please review it . Thank you.

j143 commented 4 years ago

Unfortunately, the task does not seem to be understood.

Please reread the https://github.com/j143/systemds-website/pull/8#issuecomment-660433161

After running gulp command, one should see webpage as https://github.com/j143/systemds-website/pull/2#commitcomment-40618767

rebeccadias commented 4 years ago

Thank You @j143 I will do it and get back to you .

j143 commented 4 years ago

The code looks a bit okay, I need to do some more work before merging this.

Is it possible to clean this PR, make sure only the file you have edited appears in the PR nothing else. 😅

Thank you.

j143 commented 4 years ago

Hi @rebeccadias can this PR be cleaned only showing the relevant work.

rebeccadias commented 4 years ago

Hi @j143 cleaned the PR . Thank You