Remove redundant code from release scripts - Githubissues

j143 / systemds

An opensource ML system for end-to-end data science lifecycle

Apache License 2.0

0 stars 1 forks source link

Remove redundant code from release scripts #211

Closed j143 closed 1 year ago

j143 commented 3 years ago

[ ] 1. Make this work:

https://github.com/j143/systemds/blob/da7d315bee5b476834a346291e5f01403162d702/dev/release/create-tag.sh#L76-L78

https://github.com/j143/systemds/blob/da7d315bee5b476834a346291e5f01403162d702/dev/release/create-tag.sh#L134-L138

[x] 2. Remove these lines?

https://github.com/j143/systemds/blob/da7d315bee5b476834a346291e5f01403162d702/dev/release/create-tag.sh#L93-L118

[x] 3. Do I need publish-snapshot, publish-staging:

https://github.com/j143/systemds/blob/da7d315bee5b476834a346291e5f01403162d702/dev/release/release-build.sh#L100-L128

j143 commented 3 years ago

Thoughts:

Should we enable regular snapshots on the github.
testing for gpg signing dry-run

j143 commented 1 year ago

Regular snapshots are not required
testing for gpg signing dry-run is already implemented https://github.com/apache/systemds/commit/0c3c3c297d083efa4899de6533b3e36f854ce99f