j256 / ormlite-android

ORMLite Android functionality used in conjunction with ormlite-core
http://ormlite.com/
ISC License
1.59k stars 366 forks source link

Replaced Android support-v4 library with AndroidX loader library #132

Open leandroruiz96 opened 2 years ago

leandroruiz96 commented 2 years ago

Replaced deprecated Android support-v4 library with AndroidX loader library

leandroruiz96 commented 2 years ago

Leaving this on draft because this will need to setup the Android SDK on the CCI pipeline.

fernan88 commented 2 years ago

We need this fix too!

j256 commented 2 years ago

What does this do to the backwards compatibility? @kpgalligan any comments?

j256 commented 2 years ago

Should I release 2 versions? One with the old android-support and one with AndroidX?

leandroruiz96 commented 2 years ago

That would be helpful for the people who still haven't migrated to AndroidX. But considering that the original Android support library is no longer maintained, I wouldn't keep the support version for much longer.

fernan88 commented 2 years ago

Hi @j256, do you have any update on this?

nogueirasjorge commented 2 years ago

Hi @j256! every conflict has been resolved for this pull request. Could you take a look at this update for a future merging? Thanks in advance!

j256 commented 2 years ago

Hey @leandroruiz96 , can you merge up from trunk. I see a lot of duplicate changes were are confusing the diff.

nogueirasjorge commented 2 years ago

Hey @j256, I've merged up the changes again. So, you will be able to see just the changes related to this merge request.

j256 commented 2 years ago

How can I test these changes? I'm not up on my Android testing. I'd like to verify that the old version of the generated files work as well as the new.

nogueirasjorge commented 2 years ago

To test this, you will need to package the library and import the ormlite-android.aar generated into an android project. The easiest way to do this is by placing the aar into a libs folder inside the main module in your Android project:

Screen Shot 2022-02-21 at 15 58 21

and adding it in the build.gradle as a dependency:

dependencies { implementation files('./libs/ormlite-android.aar') }

nogueirasjorge commented 2 years ago

Hi @j256, just to check. Could you test the changes? It'll be really nice to have this merged in a future release.

bio007 commented 2 years ago

Hi, this would help us a lot as well 👍

nogueirasjorge commented 1 year ago

Hi @j256, I hope you are doing well. Have you had the chance to review this branch? It'd be very helpful to have it merged.

dan-ryan commented 1 year ago

I would like to turn off Jetifier, but this library is holding that up. Would be great if this can be merged this in :)

felipehjcosta commented 1 year ago

+1