j2objc-contrib / j2objc-common-libs-e2e-test

End-to-end tests for translating, compiling, and linking common Java libraries into Objective C using j2objc
https://github.com/j2objc-contrib
Apache License 2.0
12 stars 5 forks source link

Adds testing scripts and Gson as first library. #23

Closed advayDev1 closed 8 years ago

advayDev1 commented 8 years ago

Fixes #21 Fixes #19

Do #22 first.

brunobowden commented 8 years ago

Please respond to the comments. Close to LGTM.

brunobowden commented 8 years ago

Note that the prior LGTM was a comment on a related PR, not this specific one. Ping me again when thsi is ready for another round.

advayDev1 commented 8 years ago

@brunobowden ptal - I will flatten the 2 commits once LGTY

brunobowden commented 8 years ago

LGTM after addressing last 3 comments.

advayDev1 commented 8 years ago

all done - merging.