Closed advayDev1 closed 8 years ago
@brunobowden : ready to review, but you need to do all the other PRs #23 #22 #21 first.
This is what it looks like when we know some of our libraries don't translate: https://travis-ci.org/j2objc-contrib/j2objc-common-libs-e2e-test/builds/82351797
I think it is good to have them anyway, as it documents in the logs exactly what needs to be fixed to get a working system.
The output for mixed failures and successes on builds is great. I agree that they should be separate builds to make tracking and fixes easier.
Well that's kind of annoying of github... Once I updated this PR I don't see any of your comments on the individual commit - I'd seen them before. I see you've already LGTM-ed the next PR #26 , but please do PTAL this one. I've basically updated this PR with respect to the comments from the last one #23 . @brunobowden
Fixes #14 fixes #25
No problem, happy to go through it again. I tried doing the reviews on the individual commit... so that I could isolate review to only the part that changed. It may have been that if I did the comment on the PR, then it would've preserved the comments.
LGTM after addressing prior comments.
thanks
btw: yes comments on PRs are preserved on the page (as 'outdated') even when the old commit is obliterated by git push -f
; comments on commits are preserved somewhere in the backend but people have to git reflog
or guess the right SHA to find the URL (assuming github doesn't GC the commit in the meantime since no ref points to it).
They have known issues, but we add them anyway to track when they get fixed.
Adds a proper design for multi-library projects and for libraries that depend on other libraries we also test.