search

j2objc-contrib / j2objc-common-libs-e2e-test

End-to-end tests for translating, compiling, and linking common Java libraries into Objective C using j2objc
https://github.com/j2objc-contrib
Apache License 2.0
12 stars 5 forks source link

Add unit-tests for Joda convert. #45

Closed advayDev1 closed 8 years ago

advayDev1 commented 8 years ago

Also adds a common script to get test repos from github.

Issue #30

advayDev1 commented 8 years ago

Alright, I think you can take a look @brunobowden

advayDev1 commented 8 years ago

travis is finally working again - all green @brunobowden

brunobowden commented 8 years ago

My main question is why offer flexibility on which tasks you run? For now, you're only running "build". Hopefully that should remain the case. Please explain why you want to offer more?

advayDev1 commented 8 years ago

@brunobowden ptal. Re flexibility: I'd had a plan to allow 2 travis entries for a single TEST_DIR:

  - TEST_DIR=com.google.code.gson-gson TEST_TASKS=assemble
  - TEST_DIR=com.google.code.gson-gson TEST_TASKS=check

this would allow you to have unit tests in the allowed failures but have translation/compilation in the required successes. I'll put that in the Gson cl itself though - removed from this PR.

brunobowden commented 8 years ago

LGTM - please ignore my last comments about the assemble / build ordering. I'd do that on the next PR.

advayDev1 commented 8 years ago

your suggestion is why i had added that code in the first place. unfortunately, it doesn't work as expected because we made a decision long ago that j2objc translation depends on Java unit-testing.

we may want to reconsider that.

brunobowden commented 8 years ago

Does Travis have a feature where you can mark a certain checkpoint in the build? E.g. "Complete Stages 1&2, Failed at Stage 3"? I searched but couldn't see anything.

advayDev1 commented 8 years ago

No it doesn't. The only distinction is 'install' vs 'build'. You cannot distinguish between steps of 'build' which is what we'd like