search

j2objc-contrib / j2objc-common-libs-e2e-test

End-to-end tests for translating, compiling, and linking common Java libraries into Objective C using j2objc
https://github.com/j2objc-contrib
Apache License 2.0
12 stars 5 forks source link

Run against plugin v0.4.3-alpha; fixes #33 #47

Closed advayDev1 closed 8 years ago

advayDev1 commented 8 years ago

@brunobowden ptal; reduces each build by 1.5-2 minutes

brunobowden commented 8 years ago

Given that we're referring to fixed library versions, I thought it would've been more helpful to get updates when we change the plugin? With this change, any breaking change in the plugin won't be discovered until it's published.

LGTM if you insist but I think we should look at this again.

advayDev1 commented 8 years ago

The way it stands we can't catch such errors anyway (recall our discussion in #38). I agree auto-updating would be nice, but I think we should add that as a separate branch. When potential users visit this repo, they should see the state of our released plugin by default no?

not committing to continue discussion.

advayDev1 commented 8 years ago

ping @brunobowden

brunobowden commented 8 years ago

LGTM

@advayDev1 - I would prefer a separate PR that did both build: release version and the j2objc-gradle HEAD.

advayDev1 commented 8 years ago

This is discarded as it is old actually