search

j3k0 / cordova-non-renewing-subscription

Simple API for Non-Renewing Subscriptions based on Fovea's Cordova Purchase Plugin
MIT License
19 stars 6 forks source link

possible type #15

Closed nnylip closed 7 years ago

nnylip commented 7 years ago

Possible typo: I notice on lines 494, 495 of cordova-non-renewing-subscription.js

  loadExpiryDate: options.loadExpiryDate,
  saveExpiryDate: options.loadExpiryDate,

Should it not be ?

  loadExpiryDate: options.loadExpiryDate,
  saveExpiryDate: options.saveExpiryDate,

This prevents a user defined saveExpiryDate being called. Thanks - Lou

petarov commented 7 years ago

This seems to have been fixed with Pull Request #1 in the master branch.

j3k0 commented 7 years ago

This was a typo indeed, fixed already. Thanks for the notice.

nnylip commented 7 years ago

Thanks. I was using the build that was in the demo.

On 11/03/2016 04:28 AM, Petar Petrov wrote:

This seems to have been fixed with Pull Request #1 https://github.com/j3k0/cordova-non-renewing-subscription/pull/1 in the |master| branch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/j3k0/cordova-non-renewing-subscription/issues/15#issuecomment-258085613, or mute the thread https://github.com/notifications/unsubscribe-auth/APNHCoDoDhadMjWllOVmhMvE0Y-dX5nMks5q6ZswgaJpZM4KndJM.