search

j3k0 / cordova-plugin-openwith

Get your Cordova App in the O.S. "Share" menu on iOS and Android
MIT License
138 stars 114 forks source link

Just to make the plugin work (more easily) on ios #97

Closed BenjaminPoncet closed 4 years ago

BenjaminPoncet commented 4 years ago

As it is, the plugin is very difficult to install, especially because of the ShareExtension and the App Group. And when we finally manage to install everything, the ShareExtension opens the app but doesn't transmit anything at all. I tried a lot of forks that work more or less and I finally decided to start from the base. So I propose 6 small commits to make the plugin work as it should under ios and especially in a much simpler way.

NiklasMerz commented 4 years ago

And of course a huge thank you from me for creating the PR for this upstream repo.

j3k0 commented 4 years ago

@NiklasMerz Code looks good to me too.

I do not have a test bed for this plugin anymore. I'd be tempted to trust @BenjaminPoncet and merge into master, wait a few weeks for complains then publish a release with npm if nothing is reported.

j3k0 commented 4 years ago

@BenjaminPoncet Thanks for the effort and submitting a PR 👍

j3k0 commented 4 years ago

@BenjaminPoncet - I see you've merged in your fork code from a number of other sources. Anything worth merging into here?

BenjaminPoncet commented 4 years ago

Indeed, I intend to propose a new pull request! All my ff- branches correspond to "From Fork" features that I've rebase or cherry pick and rework to be merged without conflict. But before making a pull request I test and re-test in my v- branches. For the moment, there is nothing completely satisfying (for me), everybody works in his own corner for his own needs... The next pull request I'm thinking of doing is my ios-multi-type-support branch. I'm (much simpler) rewriting the feature.

j3k0 commented 4 years ago

Great! Looking forward to this, thanks for the effort ❤️

HarelM commented 4 years ago

Has this been released to npm by any chance?