List user invitations - Githubissues

j3k0 / ganomede-invitations

Ganomede Invitations

0 stars 0 forks source link

List user invitations #1

Closed j3k0 closed 9 years ago

j3k0 commented 9 years ago

src/invitations-api.coffee is incomplete, needs to support listing of the users's invitations.

Tasks:

make sur unit test for GET /.../invitations passes, test is implemented in test/tests-invitations-api.coffee
you'll have to implement in src/invitations-api.coffee
write more test to check the error cases (invalid user, etc)
ensure good test coverage
cleanup the code.

Notes:

See README for specifications of the GET request.
Test uses fakeredis (https://github.com/hdachev/fakeredis) and other mock classes found in tests/ folder.
Check how the POST is implemented for inspiration.

Additional instructions:

run make to execute the tests.
run make coverage and open doc/coverage.html to check your progress.

j3k0 commented 9 years ago

Hey @elmigranto, let me know if you need a quick intro about the ganomede-invitations work.

elmigranto commented 9 years ago

Here's initial change to using real restify in tests.

Looks pretty neat to me, the only problem I can see is slower tests, so maybe we should look into best practices on parallelizing them later. Not a problem for now and I'm sure mocha can ran certain files only.

elmigranto commented 9 years ago

I didn't made any checks for expiring invitations for now, #4 should be addressed before we continue with this and #2.

elmigranto commented 9 years ago

This is ready.

elmigranto commented 9 years ago

I was mistakenly calling sendError without next arg, i fixed it in #2. Probably should test error sending better from now on. Shouldn't be a problem if you merge pulls one after another, but I guess this is not ideal, any advice?

j3k0 commented 9 years ago

Shouldn't be a problem if you merge pulls one after another, but I guess this is not ideal, any advice?

I merge one -> rebase the second on master -> merge the second. It looks clean in the end.

j3k0 commented 9 years ago

@elmigranto Thanks for the job on this module. You write nice, clean and maintainable code. Keep it up!