Delete invitation - Githubissues

j3k0 commented 9 years ago

src/invitations-api.coffee is incomplete, needs to support deleting an invitation.

Tasks:

make sur unit test for DELETE /.../invitations passes, test is implemented in test/tests-invitations-api.coffee
you'll have to implement in src/invitations-api.coffee
write more test to check the error cases (invalid user, invalid requests, etc)
ensure good test coverage
cleanup the code.

Notes:

See README for specifications of the DELETE request.
Test uses fakeredis (https://github.com/hdachev/fakeredis) and other mock classes found in tests/ folder.
Check how the POST is implemented for inspiration.

Additional instructions:

run make to execute the tests.
run make coverage and open doc/coverage.html to check your progress.

elmigranto commented 9 years ago

Since we reply to successful DELETE with HTTP 204 (No Content), it is not possible to send any payload. {ok: true} is in the specs, though.

Are we ok with just res.send(204)?

I also reply with 404 to requests with non-existing invitation ID and with 403 to request with wrong users (authToken is valid, but username does not match from or to). Is this ok?

elmigranto commented 9 years ago

This is ready. Take a look at this first, though.

j3k0 / ganomede-invitations

Delete invitation #2