j3k0 / ganomede-invitations

Ganomede Invitations
0 stars 0 forks source link

Send notifications #6

Closed j3k0 closed 7 years ago

j3k0 commented 9 years ago

The notification module will be configured using environment variables:

NOTIFICATIONS_PORT_8080_TCP_ADDR
NOTIFICATIONS_PORT_8080_TCP_PORT

If those env variables aren't set, just don't send notifications (but write some warning on the logs at app startup).

j3k0 commented 9 years ago

Commit 6ac0cbb says "First approximate of sending notifications". What do you think is missing?

j3k0 commented 9 years ago

I did some cleanup here: https://github.com/j3k0/ganomede-invitations/blob/3cffdeefef03dfa7d45811a360fbad19ba3d01e6/src/invitations-api.coffee#L274-L276

and solved a typo-bug in send-notification error reporting.